Rémi Bernon (@rbernon) commented about dlls/windows.devices.enumeration/tests/devices.c:
free( devices ); }
hr = IVectorView_DeviceInformation_QueryInterface(info_collection, &IID_IIterable_DeviceInformation, (void **)&info_iterable ); IVectorView_DeviceInformation_Release( info_collection );todo_wine ok( SUCCEEDED( hr ), "got hr %#lx\n", hr );- }
- if (info_iterable)
IMO adding these todo and ifs early just makes things more complicated than it needs, you don't need them if Wine doesn't reach that point anyway and as we have some generic IVector implementation now I expect you would need a single todo_wine/if to skip all the related tests, and then get all of them to pass at once when you put the implementation in place.
Note you can probably save the testing of the inners of the IVector individual methods, if this is what all these tests are about, it's already tested elsewhere and probably not worth testing in every module that duplicates it. Of course if they are checking some windows.device.enumeration specific implementation details, it's alright.