Re: [PATCH 0/2] MR661: wshom: Support default style argument in IWshShell3::Run.

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/wshom.ocx/shell.c:
> - if (FAILED(hr))
> - {
> -
>    ERR("failed to convert style argument, %#lx\n", hr);
> -
>    return hr;
> - if (is_optional_argument(style))
> -
>    show = 1;
> - else {
> -
>    VARIANT s;
> -
>    VariantInit(&s);
> -
>    hr = VariantChangeType(&s, style, 0, VT_I4);
> -
>    if (FAILED(hr))
> -
>    {
> -
>        ERR("failed to convert style argument, %#lx\n", hr);
> -
>        return hr;
> -
>    }
> -
>    show = V_I4(&s);

No need to move 's' definition here. We could reuse same variant for both 'style' and 'wait'. Error message can go too.