Re: [PATCH 0/3] MR6673: d3dx9: Move targa decoding into d3dx9, part 1.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/surface.c:
> - if (header->color_map_type && ((header->color_map_type > 1) || (!header->color_map_length)
> -
>            || (d3dx_get_tga_format_for_bpp(header->color_map_entrysize) == D3DFMT_UNKNOWN)))
> -
>    return D3DXERR_INVALIDDATA;
> -
> - switch (header->image_type & IMAGETYPE_MASK)
> - {
> -
>    case IMAGETYPE_COLORMAPPED:
> -
>        if (header->depth != 8 || !header->color_map_type)
> -
>            return D3DXERR_INVALIDDATA;
> -
>        image->format = D3DFMT_P8;
> -
>        break;
> -
> -
>    case IMAGETYPE_TRUECOLOR:
> -
>        if (d3dx_get_tga_format_for_bpp(header->depth) == D3DFMT_UNKNOWN)
> -
>            return D3DXERR_INVALIDDATA;
> -
>        image->format = d3dx_get_tga_format_for_bpp(header->depth);

Another nitpick but:
```suggestion:-2+0
            if ((image->format = d3dx_get_tga_format_for_bpp(header->depth)) == D3DFMT_UNKNOWN)
                return D3DXERR_INVALIDDATA;
```