Re: [PATCH v3 0/5] MR283: vkd3d-shader/dxil: Implement DX instruction StoreOutput.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/dxil.c:
> +}
> -
>
> +static inline unsigned int sm6_value_get_constant_uint(const struct sm6_value *value)
> +{
> - if (!sm6_value_is_constant(value))
> -
>    return UINT_MAX;
> - return register_get_uint_value(&value->u.reg);
>
> +}
> -
>
> +static struct vkd3d_shader_src_param *instruction_src_params_alloc(struct vkd3d_shader_instruction *ins,
> -
>    unsigned int count, struct sm6_parser *sm6)
>
> +{
> - struct vkd3d_shader_src_param *params = shader_parser_get_src_params(&sm6->p, count);
> - if (!params)
> - {
> -
>    sm6->p.failed = true;

Maybe an error message could be emitted at this point?