Re: [PATCH v3 0/1] MR218: vkd3d-shader: Implement GetDimensions().

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl.y:
> -
>            {
> -
>                if (!(args[ARG_MIP_LEVEL] = add_implicit_conversion(ctx, instrs, args[ARG_MIP_LEVEL],
> -
>                        hlsl_get_scalar_type(ctx, HLSL_TYPE_UINT), loc)))
> -
>                {
> -
>                    return false;
> -
>                }
> -
> -
>                continue;
> -
>            }
> -
> -
>            uint_resinfo &= hlsl_types_are_equal(params->args[j]->data_type, uint_type);
> -
> -
>            if (params->args[j]->data_type->class != HLSL_CLASS_SCALAR)
> -
>            {
> -
>                hlsl_error(ctx, loc, VKD3D_SHADER_ERROR_HLSL_INVALID_TYPE, "Expected scalar arguments.");
> -
>                break;

Maybe you should `return false` here too, so that the compiler doesn't keep trying to compile hopeless code.