Re: [PATCH v5 0/6] MR1628: ntdll: Implement Low Fragmentation Heap.

[Jinoh Kang (＠iamahuman)]

Jinoh Kang (@iamahuman) commented about dlls/ntdll/heap.c:
>      status = STATUS_NO_MEMORY;
>  else if (block_size >= HEAP_MIN_LARGE_BLOCK_SIZE)
>      status = heap_allocate_large( heap, heap_flags, block_size, size, &ptr );
> - else if (!heap_allocate_block_lfh( heap, heap_flags, block_size, size, &ptr ))
> -
>    status = STATUS_SUCCESS;
> else
>    {
>        heap_lock( heap, heap_flags );
>        status = heap_allocate_block( heap, heap_flags, block_size, size, &ptr );
>        heap_unlock( heap, heap_flags );
> -
> -
>    if (!status && heap->categories)
> -
>    {
> -
>        block_size = block_get_size( (struct block *)ptr - 1 );
> -
>        heap->categories[BLOCK_SIZE_CATEGORY( block_size )].blocks_alive++;
> -
>        heap->categories[BLOCK_SIZE_CATEGORY( block_size )].blocks_total++;

I think we can move this inside the heap critical section. Same for the other one.