Re: [PATCH 0/4] MR951: ntdll: Add initial support for DOS file attributes (attempt 3)

[Zebediah Figura]

On 9/28/22 18:24, Erich Hoover (@ehoover) wrote:
> > I basically downloaded these patches, tried to test them with my samba
> > setup, found they silently didn't work, and discovered it was because we
> > were getting ERANGE.
>
> If you create the hidden/system/whatever file on the Wine side then Samba should pick it up correctly the other direction.

Indeed. Unfortunately I tested the broken direction first ;-)
> > As long as the format has a fixed (or capped) size, which seems to be
> > true of both the Samba 3 and Samba 4 formats, I think it'd make sense to
> > be noisy about ERANGE, since that implies there's a new format we can't
> > parse.
>
> I think that `FIXME_ONCE` might be a better choice here, as you will otherwise get this output for _everything_.

Sure, makes sense.