On Wed Apr 5 18:34:13 2023 +0000, Paul Gofman wrote:
Also, any reason not to add the tests upfront? I think it'd make the
changes more obvious if the tests were added upfront or in a lockstep, and the implementation incrementally fixing the todo_wine. Well, the whole test logic WRT actual samples will be just broken until the implementation is there and can probably only be skipped. So I considered that doing that upfront and updating the test on the way won't make most interesting parts clearer and will only add some back and force test tweaking along the patchset. Still if you think that is more convenient I can do that, should I?
You can probably ignore the `QueryInterface` suggestion if you use the `IMFVideoSampleAllocatorEx` like I described below, as in this case you also won't have to query the iface in the decoder and can just forward the message parameter.
Regarding the tests, I wouldn't mind having a first patch introducing basic `ProcessMessage` / `MFT_MESSAGE_SET_D3D_MANAGER` tests, then adding the buffer tests.
I'm probably fine with all the tests added at once, but I think having them upfront is better to show what gets implemented.