On Thu Feb 23 01:37:16 2023 +0000, Ziqing Hui wrote:
Also, please don't put more than one C statement on the same line.
Do you mean code like this: `case WG_WMV_VIDEO_FORMAT_WMV1: wmv_format = "WMV1"; break;` ? If do, I just follow the parttern in wg_format_to_caps_video_h264(). Should I put `wmv_format = "WMV1";` and `break;` into new lines?
Wrt patch 3/4, where are you running into this?
In wmv_decoder: media_object_SetOutputType(), the AvgTimePerFrame passed in could be zero (it's legal to be zero on Windows), which will leads to the fps_d of input_format or output_format in wg_transform_create() to be zero.
Then in wg_format_to_caps_video_wmv(), we use gst_caps_set_simple() to set "framerate" to be fps_n/fps_d, then gstreamer will complain abount FRACTION's is zero. It happens in the WMV DMO decoder tests in mf/tests/transform.c