3 Oct
2023
3 Oct
'23
9:21 a.m.
On Tue Sep 26 23:38:34 2023 +0000, Alfred Agrell wrote:
I don't know how many emails/etc gitlab sends, so I'm not sure if you saw it, but I implemented the entire thing; I think it's correct, but there's a fixme for the lack of tests (adding that is too far out of scope to belong in this MR). I could remove it if you don't want untested code floating around; now that I know what exactly it's trying to do, and what it's actually doing, it's not hard to work around it in the test instead.
I don't know whether this is correct or not, I think it'd be better to leave this aspect aside for now as like you said this is going a bit out of the scope of this MR.