Re: [PATCH v6 0/2] MR2282: d3d9: Disable instancing for not-indexed drawing

[Illia Polishchuk (＠illia.a.polishchuk)]

On Tue Feb 28 21:17:54 2023 +0000, Henri Verbeet wrote:
> Note that this will still respect D3DSTREAMSOURCE_INSTANCEDATA for
> DrawPrimitive()/DrawPrimitiveUP(). That may very well be the correct
> behaviour, but something like "d3d9: Always draw only a single instance
> for non-indexed draws." would be a more accurate description of the commit.
> > -    wined3d_device_context_draw_indexed(device->immediate_context,
>
> base_vertex_idx, start_idx, index_count, 0, 0);
> > - wined3d_device_context_draw_indexed(device->immediate_context,
>
> base_vertex_idx, start_idx, index_count, 0,
> > -
> >        wined3d_stateblock_get_state(device->state)->streams[0].frequency);
>
> I think you should be able to use "device->stateblock_state" instead of
> "wined3d_stateblock_get_state(device->state)" here, as well as in d3d9_device_DrawIndexedPrimitiveUP().
> There are a couple of places with trailing spaces in this series.

Makes sense. Thank you for the tips, updated MR