13 May
2025
13 May
'25
2:55 p.m.
On Tue May 13 14:32:13 2025 +0000, Alanas Tebuev wrote:
do you want `WCHAR *address` and `DWORD sizeInBytes` to be not inside `COMCTL32_UnicodeBuffer`?
grep --recursive --fixed-strings --include '*.h' '_array_reserve'libs/vkd3d/libs/vkd3d-shader/hlsl.h:static inline bool hlsl_array_reserve(struct hlsl_ctx *ctx, void **elements, libs/vkd3d/libs/vkd3d-shader/hlsl.h: bool ret = vkd3d_array_reserve(elements, capacity, element_count, element_size); libs/vkd3d/libs/vkd3d-shader/vkd3d_shader_private.h:bool shader_instruction_array_reserve(struct vkd3d_shader_instruction_array *instructions, unsigned int reserve); libs/vkd3d/include/private/vkd3d_memory.h:bool vkd3d_array_reserve(void **elements, size_t *capacity, size_t element_count, size_t element_size); dlls/windowscodecs/wincodecs_private.h:extern bool wincodecs_array_reserve(void **elements, size_t *capacity, size_t count, size_t size); dlls/mf/mf_private.h:static inline BOOL mf_array_reserve(void **elements, size_t *capacity, size_t count, size_t size) dlls/dwrite/dwrite_private.h:static inline BOOL dwrite_array_reserve(void **elements, size_t *capacity, size_t count, size_t size) dlls/gdi32/uniscribe/usp10_internal.h:BOOL usp10_array_reserve(void **elements, SIZE_T *capacity, SIZE_T count, SIZE_T size); dlls/mfreadwrite/mf_private.h:static inline BOOL mf_array_reserve(void **elements, size_t *capacity, size_t count, size_t size) dlls/opcservices/opc_private.h:static inline BOOL opc_array_reserve(void **elements, size_t *capacity, size_t count, size_t size) dlls/mfplat/mfplat_private.h:static inline BOOL mf_array_reserve(void **elements, size_t *capacity, size_t count, size_t size) dlls/wined3d/wined3d_private.h:BOOL wined3d_array_reserve(void **elements, SIZE_T *capacity, SIZE_T count, SIZE_T size); dlls/d3drm/d3drm_private.h:BOOL d3drm_array_reserve(void **elements, SIZE_T *capacity, SIZE_T element_count, SIZE_T element_size); dlls/d2d1/d2d1_private.h:static inline BOOL d2d_array_reserve(void **elements, size_t *capacity, size_t count, size_t size) dlls/uiautomationcore/uia_private.h:static inline BOOL uia_array_reserve(void **elements, SIZE_T *capacity, SIZE_T count, SIZE_T size)
Yes, just the way it looks is not great. This part for example is unnecessary syntax to assign two fields:
```c *unicodeBuffer = (COMCTL32_UnicodeBuffer) { .address = address, .sizeInBytes = minSizeInBytes }; ```
Naming is also too complicated, all this is is "buffer" and "size". I just noticed that it somehow looks worse than it used to be in pager.c I would just use two separate fields.