Re: [PATCH v4 0/13] MR626: vkd3d-utils: Constant buffer reflection without vkd3d-shader.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-utils/reflection.c:
> - if (FAILED(hr = hresult_from_vkd3d_result(vkd3d_shader_scan(&compile_info, NULL))))
> -
>    return hr;
> -
> - if ((ret = vkd3d_shader_parse_dxbc(&compile_info.source, 0, &dxbc_desc, NULL)))
> - {
> -
>    vkd3d_shader_free_scan_signature_info(&reflection->signature_info);
> -
>    return hresult_from_vkd3d_result(ret);
> - }
> -
> - for (unsigned int i = 0; i < dxbc_desc.section_count; ++i)
> - {
> -
>    const struct vkd3d_shader_dxbc_section_desc *section = &dxbc_desc.sections[i];
> -
> -
>    if (section->tag == TAG_RDEF)
> -
>    {
> -
>        if (found_rdef)

This can never happen, `found_rdef` is never set to `true`.