On Mon Nov 6 07:17:39 2023 +0000, Alex Henrie wrote:
It's up to you as the maintainer. I expect that eventually wine/heap.h will be deleted, so the calls to heap_alloc will either need to be changed to malloc or to HeapAlloc. And if future tests use strdup or wcsdup, that would look inconsistent alongside HeapAlloc.
There are other benefits to using CRT allocation functions too, such as better compiler warnings and better static analyzer warnings.