On Wed May 14 15:45:05 2025 +0000, Jinoh Kang wrote:
If you're going to use FAILED(hr) we might as well scrap the test, there's little to no way the function would succeed with an invalid pointer if not outright crash. @maljaf, you probably added the test because the app depends on it, right? Otherwise we could just remove the NULL check entirely in implementation side and let it crash. Maybe not if that makes the API inconsistent with other ones.
I don't see any reason to remove it, though I don't have a strong opinion about it. In any case, I'm not changing anything unless @rbernon says otherwise.