Re: [PATCH 0/2] MR3915: ddraw/tests: Test WS_EX_TOPMOST restoration.

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/wined3d/swapchain.c:
>  s->style = fullscreen_style(state->style);
>  s->exstyle = fullscreen_exstyle(state->exstyle);
>  s->set_style = true;
> - s->register_topmost_timer = !!(state->desc.flags & WINED3D_SWAPCHAIN_REGISTER_TOPMOST_TIMER);
> - s->set_topmost_timer = (s->window_pos_after == HWND_TOPMOST && !(s->flags & SWP_NOZORDER));

This set_topmost_timer handling is odd, isn't this always going to be true? We always set HWND_TOPMOST above, and I don't think a client can meaningfully specify both WINED3D_SWAPCHAIN_REGISTER_TOPMOST_TIMER and WINED3D_SWAPCHAIN_NO_WINDOW_CHANGES.