Re: [PATCH v5 0/5] MR2870: gdiplus: Support playing back pen custom end line cap.

[Zhiyi Zhang (＠zhiyi)]

On Wed May 24 08:47:22 2023 +0000, Zhiyi Zhang wrote:
> changed this line in [version 5 of the diff](/wine/wine/-/merge_requests/2870/diffs?diff_id=48419&start_sha=016f0988e3542325d5f1faca933b6b89f4f2edeb#57baf6156e920ffd29ecd76bb1d39bb8590dc875_3962_3962)

v5: Move the GdipCloneImage() call after sync_metafile(). Handle emf pen records with custom line cap path data with 'R' and 'C' flags set.
> Uh, what's the reason for this copy?

Because the latter GdipGetHemfFromMetafile() call will make metafile->hemf NULL. Without a cloned image file, later play_metafile() will fail because the second GdipGetHemfFromMetafile() fails.

Thanks for the review.