Re: [PATCH v2 0/4] MR288: hlsl: Some fixes caught by Wine tests.

[Henri Verbeet (＠hverbeet)]

> @@ -2627,7 +2627,8 @@ bool hlsl_sm4_usage_from_semantic(struct hlsl_ctx *ctx, const struct hlsl_semant
>      return true;
>  }
>
> -static void add_section(struct dxbc_writer *dxbc, uint32_t tag, struct vkd3d_bytecode_buffer *buffer)
> +static void add_section(struct hlsl_ctx *ctx, struct dxbc_writer *dxbc,
> +        uint32_t tag, struct vkd3d_bytecode_buffer *buffer)
>  {
>      /* Native D3DDisassemble() expects at least the sizes of the ISGN and OSGN
>       * sections to be aligned. Without this, the sections themselves will be
> @@ -2635,6 +2636,9 @@ static void add_section(struct dxbc_writer *dxbc, uint32_t tag, struct vkd3d_byt
>      size_t size = bytecode_align(buffer);
>
>      dxbc_writer_add_section(dxbc, tag, buffer->data, size);
> +
> +    if (buffer->status < 0)
> +        ctx->result = buffer->status;
>  }
>
>  static void write_sm4_signature(struct hlsl_ctx *ctx, struct dxbc_writer *dxbc, bool output)

I'll approve this, but I don't think this is quite right; ultimately we'd like to push hlsl_ctx out of e.g. write_sm4_shdr(), instead of into things like add_section().