3 Apr
2023
3 Apr
'23
11:46 p.m.
On Wed Mar 29 13:17:17 2023 +0000, Giovanni Mascellani wrote:
I'm pretty sleepy right now, but this doesn't look right either. For example, if you want to flush the whole resource the `(right, bottom, back)` point that is involved in that computation is a whole slice (plus a line, plus a point) past the end of the resource. Wouldn't you want something like `get_data_offset(right - 1, bottom - 1, back - 1) + 1`, at least for uncompressed formats? As I said, I might be missing something here.
Y...es, you're right, almost. It should be get_data_offset(right, bottom - 1, back - 1), which is almost what you said except that it correctly accounts for pixel size. Fixed in v4.