On Tue Mar 11 09:24:56 2025 +0000, Rémi Bernon wrote:
Yes you're right, it's an evr test. Well, then maybe a test for a media sink with NULL type would tell whether it can be NULL, which seems weird. If it's indeed not allowed, the logic should probably be adjusted to reject it on stream creation so we can later assume it's not NULL.
I just did a tests on win10 with these minutes ago:
``` diff --git a/dlls/mf/tests/mf.c b/dlls/mf/tests/mf.c index 53f22809dc4..2514ffc5160 100644 --- a/dlls/mf/tests/mf.c +++ b/dlls/mf/tests/mf.c @@ -5959,6 +5959,8 @@ static void test_mpeg4_media_sink(void) /* Test adding and removing stream sink. */ if (!(flags & MEDIASINK_FIXED_STREAMS)) { + hr = IMFMediaSink_AddStreamSink(sink, 123, NULL, &stream_sink); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); hr = IMFMediaSink_AddStreamSink(sink, 123, video_type, &stream_sink); ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); IMFStreamSink_Release(stream_sink);
```
It will crash the tests. So I think it is not allowed.