Re: [PATCH v3 0/1] MR8888: opengl32/tests: Add 16-bit bitmap rendering tests

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/opengl32/tests/opengl.c:
> - ok(success != 0, "Failed to DescribePixelFormat (error: %lu)\n", GetLastError());
> - /* Likely MSDN inaccuracy: According to the PIXELFORMATDESCRIPTOR docs, alpha bits are excluded
> -
> * from cColorBits. It doesn't seem like that's true. */
> - ok(pfd.cColorBits == 16, "Wrong amount of color bits (got %d, expected 16)\n", pfd.cColorBits);
> - todo_wine ok(pfd.cRedBits == 5, "Wrong amount of red bits (got %d, expected 5)\n", pfd.cRedBits);
> - todo_wine ok(pfd.cGreenBits == 5, "Wrong amount of green bits (got %d, expected 5)\n", pfd.cGreenBits);
> - todo_wine ok(pfd.cBlueBits == 5, "Wrong amount of blue bits (got %d, expected 5)\n", pfd.cBlueBits);
> - /* Quirky: It seems that there's an alpha bit, but it somehow doesn't count as one for
> -
> * DescribePixelFormat. On Windows cAlphaBits is zero.
> -
> * ok(pfd.cAlphaBits == 1, "Wrong amount of alpha bits (got %d, expected 1)\n", pfd.cAlphaBits); */
> - todo_wine ok(pfd.cRedShift == 10, "Wrong red shift (got %d, expected 10)\n", pfd.cRedShift);
> - todo_wine ok(pfd.cGreenShift == 5, "Wrong green shift (got %d, expected 5)\n", pfd.cGreenShift);
> - /* Blue shift bits is driver-dependent so this test is likely to pass.
> -
> * I've used `todo_wine_if` to disable the warning. */
> - todo_wine_if(pfd.cBlueShift != 0)
> -
>        ok(pfd.cBlueShift == 0, "Wrong blue shift (got %d, expected 0)\n", pfd.cBlueShift);

This will make the todo_wine stay unnoticed once the implementation is fixed, do we actually need it? Could it be either removed or made unconditional?