Re: [PATCH v5 0/8] MR2098: mshtml: Implement synchronous XMLHttpRequests.

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/mshtml/tests/xhr.js:
> -
>        return;
> -
>    window.setTimeout(function() { a.push("timeout_sync"); }, 0);
> -
>    window.postMessage("_sync", "*");
> -
> -
>    sync_xhr_nested = new XMLHttpRequest();
> -
>    sync_xhr_nested.open("POST", "echo.php", false);
> -
>    sync_xhr_nested.onreadystatechange = function() {
> -
>        a.push("nested(" + sync_xhr_nested.readyState + ")");
> -
>        if(sync_xhr_nested.readyState == 4) {
> -
>            window.setTimeout(function() { a.push("timeout_nested"); }, 0);
> -
>            window.postMessage("_nested", "*");
> -
> -
>            var e = document.createEvent("Event");
> -
>            e.initEvent("click", true, false);
> -
>            async_xhr.dispatchEvent(e);
> -
>            document.fireEvent("ondblclick", document.createEventObject());

fireEvent is not exposed in IE11 mode, so this will throw an exception here. It's harmless in this case, but I'd suggest to make it conditional (and probably similar to above, check it immediately instead of using a.push).