On Wed Apr 19 15:46:30 2023 +0000, Zebediah Figura wrote:
This is the same except for the error message. I'm not honestly sure if the difference between an sm1 sampler and and sm4 sampler is enough to justify the different error messages anyway.
In the next patch, "vkd3d-shader/hlsl: Track objects sampling dimension.", the resource loads where the resource is a sampler have to be handled differently (to handle the sampler_dim), so the separation makes sense.
Regarding the error messages, refer to https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/159#note_30003 .