Re: [PATCH v4 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/tests/effect.c:
> - }
>
> +}
> -
>
> +static void test_effect_setrawvalue(IDirect3DDevice9 *device)
> +{
> - char expected_bit_buf[33] = { '\0' };
> - char result_bit_buf[33] = { '\0' };
> - unsigned int x, y, single_size;
> - ID3DXEffect *effect;
> - void *result_buf;
> - int memcmp_ret;
> - HRESULT hr;
> -
> - hr = D3DXCreateEffect( device, test_set_raw_value_blob,
> -
>        sizeof(test_set_raw_value_blob), NULL, NULL, 0, NULL, &effect, NULL );
> - ok( hr == D3D_OK, "Got result %#1.1x, expected 0 (D3D_OK).\n", hr );

```suggestion:-0+0
    ok(hr == D3D_OK, "Unexpected hr %#x.\n", hr);
```

As a general comment, in d3d code we don't put a whitespace after the opening parenthesis (or a whitespace before the closing parenthesis) of function calls or operators.