Re: [PATCH v3 0/10] MR1537: windows.media: Partially implement caption properties.

[Mohamad Al-Jaf (＠maljaf)]

On Fri Nov 25 04:55:13 2022 +0000, Mohamad Al-Jaf wrote:
> I've added comments that clarify the expected behavior. Is this better?
> Also, I've removed the checks for the Color struct as they differ
> depending on the opacity and colors set. The function only succeeds when
> the relevant Color property is set to something other than Default;
> Opacity has no effect.

I suppose it's better to add a check for ClosedCaptionColor_Default rather than a comment. Seems like it clarifies it a bit more as the expected behavior.