Re: [PATCH v15 0/6] MR6402: bluetoothapis: Implement basic SDP methods.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/bluetoothapis/tests/sdp.c:
> -
>    test_BluetoothSdpGetElementData( test_cases[i].stream, test_cases[i].size, test_cases[i].error,
> -
>                                    &test_cases[i].data );
> -
>    if (test_cases[i].error != ERROR_SUCCESS)
> -
>    {
> -
>        winetest_pop_context();
> -
>        continue;
> -
>    }
> -
> -
>    while (n < test_cases[i].container_size)
> -
>    {
> -
>        SDP_ELEMENT_DATA container_elem = {0};
> -
> -
>        winetest_push_context( "test_cases[%d].sequence[%d]", (int)i, (int)n );
> -
>        ret = BluetoothSdpGetContainerElementData( test_cases[i].data.data.sequence.value,
> -
>                                                   test_cases[i].data.data.sequence.length,
> -
>                                                   &handle, &container_elem );

Specifically, as it's implemented separately I would suggest to split these tests as well, test one function, the implement it.

BluetoothSdpGetContainerElementData tests for instance could be split to a separate change, then implemented.