On Fri May 17 08:36:29 2024 +0000, Rémi Bernon wrote:
I don't see why this is necessary, in the commit above we just pass the object size when looking for a mmaped block (right now it's fixed but could be variable later), and look a block containing [offset, offset + size), or mmap a new one which will include the range.
Yes, I think it's better.
It's hard for me to comment on details of thread input without seeing the code, but it sounds to me that a helper that a helper that returns a pointer from an offset could be just shared between both (and other user objects like windows), while the "locator" is specific to the use case. In this MR, that just adds unnecessary extra server call.