Re: [PATCH 0/1] MR7243: msvcp140: Add padding to _Cnd_t.

[Piotr Caban (＠piotr)]

Piotr Caban (@piotr) commented about dlls/msvcp140/tests/msvcp140.c:
>  cm.cnd = cnd;
>  cm.mtx = mtx;
>  cm.timed_wait = FALSE;
> -
>
> ok(cnd->cv.Ptr == 0, "cnd.cv = %p\n", cnd->cv.Ptr);
> p__Thrd_create(&threads[0], cnd_wait_thread, (void*)&cm);
>
> WaitForSingleObject(cm.initialized, INFINITE);
> p__Mtx_lock(mtx);
> p__Mtx_unlock(mtx);
> -
>
> todo_wine
> -
>
> ok(cnd->cv.Ptr != 0, "cnd.cv = %p\n", cnd->cv.Ptr);

I don't think the tests should be based on internal `CONDITION_VARIABLE` structure. If it really needs to be tested it's probably better to mix `_Cnd_*` calls with `SleepConditionVariableSRW`/`WakeConditionVariable`. You can also try to limit the tests to checking size of memory block allocated by `_Cnd_init` only.