Re: [PATCH v8 0/8] MR707: vkd3d-shader/dxil: TGSM part 2.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/dxil.c:
>  return true;
>
> }
>
> +static bool sm6_value_validate_is_pointer_to_i32(const struct sm6_value *value, struct sm6_parser *sm6)
> +{
> - if (!sm6_type_is_pointer(value->type) || !sm6_type_is_i32(value->type->u.pointer.type))
> - {
> -
>    WARN("Operand result type %u is not a pointer to i32.\n", value->type->class);
> -
>    vkd3d_shader_parser_error(&sm6->p, VKD3D_SHADER_ERROR_DXIL_INVALID_OPERAND,
> -
>            "An int32 pointer operand passed to a DXIL instruction is not an int32 pointer.");

I see there are a few already, but I find this type of error message a bit confusing. What does it mean that an int32 pointer operand is not an int32 pointer? Maybe it should be something like "Expected an int32 pointer, got something else"?