29 Nov
2024
29 Nov
'24
12:58 p.m.
On Fri Nov 29 12:08:49 2024 +0000, Dmitry Timoshkov wrote:
changed this line in [version 2 of the diff](/wine/wine/-/merge_requests/6923/diffs?diff_id=146185&start_sha=3da239d3e9694410e4f3b4f299c4b8352ffd9ab5#51bc191c8a1fc172f9ad299dd009ef2d24dfa043_6290_6290)
Confirmed, thanks.
For background, I believe the general rule is that every possible combination of arguments (regardless of whether they are semantically invalid or not) should fall into exactly one of the two cases:
1. It matches Windows behavior as demonstrated by conformance tests. 2. It emits, or ensures that it has emitted at least once, a FIXME (or WARN depending on the circumstances).
The combination `params == NULL && size != 0` fell into neither, leading to this thread.