Re: [PATCH v8 0/6] MR1857: Draft: comdlg32: IFileDialog navigation bar

[Esme Povirk (＠madewokherd)]

Esme Povirk (@madewokherd) commented about dlls/comdlg32/navbar.c:
> -
>
> +static LRESULT NAVBAR_PATHEDIT_NCCalcSize(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam)
> +{
> - NCCALCSIZE_PARAMS *ncp = (NCCALCSIZE_PARAMS *)lparam;
> -
> - if (!wparam)
> -
>    goto exit;
> -
> - /* vertically center the text */
> - ncp->rgrc[0].top += NAVBAR_PATHEDIT_NCOffset(hwnd);
> -
>
> +exit:
> - return DefSubclassProc(hwnd, msg, wparam, lparam);
>
> +}
> -
>
> +static LRESULT NAVBAR_PATHEDIT_NCPaint(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam)

This seems complicated. Wouldn't it be easier to adjust the control's size and position?

I remember you mentioned issues with controls drawing over other controls. You might need the WS_CLIPCHILDREN style?