Re: [PATCH v3 0/6] MR2568: win32u: Support setting the current mode using gdi_device_manager.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/winex11.drv/display.c:
>          handler->free_monitors(monitors, monitor_count);
>
> -
>        settings_handler.get_current_mode( adapters[adapter].id, &current_mode );
>        if (!settings_handler.get_modes( adapters[adapter].id, EDS_ROTATEDMODE, &modes, &mode_count ))
>            continue;
>
>        for (mode = modes; mode_count; mode_count--)
>        {
> -
>            TRACE( "mode: %p\n", mode );
> -
>            device_manager->add_mode( mode, FALSE, param );
> -
>            TRACE("mode: %ux%u %ubits %uHz rotated %u degrees",
> -
>                  (unsigned int)mode->dmPelsWidth, (unsigned int)mode->dmPelsHeight,
> -
>                  (unsigned int)mode->dmBitsPerPel, (unsigned int)mode->dmDisplayFrequency,
> -
>                  (unsigned int)mode->dmDisplayOrientation * 90);

Imho would be a good thing to introduce a `debugstr_devmode` helper to print these. You probably can assume these fields are there, and add `dmPosition` if `DM_POSITION` is set, and removing the need for the split line traces (which I personally find confusing). Also please keep the spacing in the parens, as it was.