[PATCH v5 3/3] shell32: check for SHGSI_ICON flag before attempting to load the icon

[Kieran Geary]

From: Kieran Geary

---
 dlls/shell32/iconcache.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/dlls/shell32/iconcache.c b/dlls/shell32/iconcache.c
index 936fad1c3e1..99bf504eb39 100644
--- a/dlls/shell32/iconcache.c
+++ b/dlls/shell32/iconcache.c
@@ -1007,7 +1007,10 @@ HRESULT WINAPI SHGetStockIconInfo(SHSTOCKICONID id, UINT flags, SHSTOCKICONINFO
     if (flags)
         FIXME("flags 0x%x not implemented\n", flags);

-    sii->hIcon = LoadIconW(GetModuleHandleW(sii->szPath), MAKEINTRESOURCEW(IDI_SHELL_FILE));
+    sii->hIcon = NULL;
+    if (flags & SHGSI_ICON)
+      sii->hIcon = LoadIconW(GetModuleHandleW(sii->szPath), MAKEINTRESOURCEW(IDI_SHELL_FILE));
+
     sii->iSysImageIndex = -1;

TRACE("%3d: returning %s (%d)\n", id, debugstr_w(sii->szPath), sii->iIcon);