Essentially, yes. I'm not necessarily convinced that we fully need to resolve that as part of this MR, but plumbing through a "use_dxcompiler" flag everywhere doesn't seem like a step in the right direction; I'd already feel a fair bit better about this if it was expressed in terms of minimum/maximum shader models. I.e., something along the lines of
run_shader_tests_d3d12(SHADER_MODEL_4_0, SHADER_MODEL_5_1); run_shader_tests_d3d12(SHADER_MODEL_6_0, SHADER_MODEL_6_0);
instead of
run_shader_tests_d3d12(false); run_shader_tests_d3d12(true);
Yeah, that's already better. It still conflates the SM and the compiler, which is a thing I'd like to eventually disentangle, but that doesn't need to happen in this MR, and I can take responsibility for that.