Re: [PATCH v7 0/7] MR443: tests: Add some tests for effects groups syntax.

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about libs/vkd3d-shader/hlsl_codegen.c:
>          return VKD3D_ERROR_INVALID_ARGUMENT;
>  }
>
> }
> -
>
> +int hlsl_emit_effect_binary(struct hlsl_ctx *ctx, struct vkd3d_shader_code *out)
> +{
> - struct hlsl_ir_var *var;
> -
> - /* Reset generated names to simplify serialization. */
> - LIST_FOR_EACH_ENTRY(var, &ctx->globals->vars, struct hlsl_ir_var, scope_entry)
> - {
> -
>    enum hlsl_base_type type = var->data_type->base_type;
> -
> -
>    if (type == HLSL_TYPE_TECHNIQUE
> -
>            || type == HLSL_TYPE_TECHNIQUE10
> -
>            || type == HLSL_TYPE_TECHNIQUE11)

Would it make sense to have a single HLSL_TYPE_TECHNIQUE plus a field for the version?