Re: [PATCH 0/1] MR8049: winhttp: Add a cache to WinHttpDetectAutoProxyConfigUrl().

[Hans Leidekker (＠hans)]

Hans Leidekker (@hans) commented about dlls/winhttp/session.c:
>      return FALSE;
>  }
>  *url = NULL;
> -
> - AcquireSRWLockExclusive( &apc_cache_lock );
> - /* FIXME: use NotifyIpInterfaceChange once that's implemented */
> - if (notifyaddr_handle == INVALID_HANDLE_VALUE)
> -
>    NotifyAddrChange( &notifyaddr_handle, &notifyaddr_ol );
> -
> - if ((notifyaddr_handle != INVALID_HANDLE_VALUE) &&
> -
>    GetOverlappedResult( notifyaddr_handle, &notifyaddr_ol, &bytes, FALSE ))
> - {
> -
>    TRACE( "network config changed, invalidating cache\n" );
> -
>    dhcp_cache_valid = dns_cache_valid = FALSE;
> -
>    notifyaddr_handle = INVALID_HANDLE_VALUE;
> -
>    NotifyAddrChange( &notifyaddr_handle, &notifyaddr_ol );

NotifyAddrChange() seems appropriate for DHCP address changes (although IPv4 only). URLs detected via DNS probably change less often but any change wouldn't be handled by this code. It's not clear what would trigger a change, perhaps add a timer using the TTL on the hostname record?. I think it's okay to ignore that for now.