On Sun Dec 3 07:43:05 2023 +0000, Fabian Maurer wrote:
FWIW, I still don't think it's a bad idea to allow being more selective. If just the `Z:` folder was the issue, I would have split that off. But this MR doesn't adress any of the problems Alexandre mentioned:
So why do we need a separate mechanism, with an ad-hoc environment
variable? Why is it only usable at prefix creation? Is there a way to unify the features, or make them easier to use? How is it different from `winetricks sandbox`? etc. etc. If we add `WINEISOLATEHOME` and later decide we want to have `Z:` isolated as well, we'd need `WINEISOLATEROOT` as well, and I'd personally much prefer a WINEISOLATE with options like WINEDEBUG.
For the first point Alexandre made: I think the reason for having the separate mechanism are pretty clear, at least to me. Points 2 and 3: The only usable at prefix creation is a feature, winecfg can be used to configure it after the creation of the prefix and this variable can be used to configure it beforehand (or something along those lines). Point 4: It's different since you can set this variable before the prefix is created and additionally you won't need to use a helper script that you have to download on the side to achieve a rather common use case of isolating the home dir folders.
I'm not exactly sure if there's a negative to adding a second env variable for isolating the Z: drive, I feel like they should have different variables because they do vastly different things. Both ways feel valid to me, but one is a lot easier to implement