Re: [PATCH v3 0/7] MR551: win32u: Complete support for display modes in nulldrv.

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/win32u/sysparams.c:
>  devmode->dmSize = offsetof(DEVMODEW, dmICMMethod);
>  memset( &devmode->dmDriverExtra, 0, devmode->dmSize - offsetof(DEVMODEW, dmDriverExtra) );
>
> - if (index == ENUM_REGISTRY_SETTINGS) ret = read_registry_settings( adapter_path, devmode );
> - if (index == ENUM_REGISTRY_SETTINGS) ret = read_registry_settings( adapter_path, ENUM_REGISTRY_SETTINGS, devmode );
> /* if EDS_ROTATEDMODE is not specified, enumerate modes with the same display orientation as current */
> else if (index != ENUM_CURRENT_SETTINGS && (flags & EDS_ROTATEDMODE)) ret = TRUE;
> - else ret = user_driver->pGetCurrentDisplaySettings( device_name, devmode );
> - else
> - {
> -
>    ret = user_driver->pGetCurrentDisplaySettings( device_name, devmode );
> -
>    if (!ret) ret = read_registry_settings( adapter_path, ENUM_CURRENT_SETTINGS, devmode );

It seems better to make this into a get_current_display_settings() function