6 Feb
2024
6 Feb
'24
5:49 p.m.
On Tue Feb 6 16:34:40 2024 +0000, Rémi Bernon wrote:
When considering this commit alone, this is still not called anywhere so all of this is dead code. You need to introduce something that uses these stubs at the same time or before they are added. In this particular case, you could probably split the MIDI parsing commit, introduce the file parser helper first, add these stubs in a separate commit (instantiating the tracks from the parser), and implementing track parsing in a third one for instance.
In general I agree with you. But those stubs are really trivial basically just logging that they have been called. Demanding they are used in tests feels a bit pedantic.