Re: [PATCH 0/4] MR692: vkd3d-shader/fx: Add "child-effect" compilation option.

[Zebediah Figura (＠zfigura)]

> -
>    case HLSL_TYPE_PIXELSHADER:
> -
>    case HLSL_TYPE_VERTEXSHADER:
> -
>        /* FIXME: write shader blobs, once parser support works. */
> -
>        for (i = 0; i < elements_count; ++i)
> -
>            put_u32(buffer, 0);
> -
>        ++fx->shader_variable_count;
> -
>        break;

We shouldn't be returning success if we're not going to output correct shader code.

The lack of tests here is also concerning.