Re: [PATCH v6 0/6] MR4140: uxtheme/tests: Add some tests for OpenThemeData() with various app/class names.

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/uxtheme/msstyles.c:
> -
> -
>    parse_app_class_name(buf, szAppName, szClassName);
> -
>    if (szAppName[0])
> -
>        cls = MSSTYLES_FindClass(tfActiveTheme, szAppName, szClassName);
> -
>    else
> -
>        cls = MSSTYLES_FindClass(tfActiveTheme, pszAppName, szClassName);
>    if(cls) break;
> }
>    if(!cls && *start) {
> -
>    lstrcpynW(szClassName, start, ARRAY_SIZE(szClassName));
> -
>    cls = MSSTYLES_FindClass(tfActiveTheme, pszAppName, szClassName);
> -
>    parse_app_class_name(start, szAppName, szClassName);
> -
>    if (szAppName[0])
> -
>        cls = MSSTYLES_FindClass(tfActiveTheme, szAppName, szClassName);
> -
>    else
> -
>        cls = MSSTYLES_FindClass(tfActiveTheme, pszAppName, szClassName);

Let's put these parse and find parts into a find_app_class() helper to avoid code duplication. So that you don't need to make the same changes twice in the patch set.

Let's use "szAppName[0] ? szAppName : pszAppName" instead. It will look cleaner.