On Thu Mar 21 12:03:47 2024 +0000, Jinoh Kang wrote:
FWIW we do read user shared data (which counts as "wineserver communication") without a macro. In addition, our session shared mapping is quite similar to `gSharedInfo`, which also exists on Windows (which doesn't involve a "wineserver"). Also, the "wineserver communication" is unidirectional (client doesn't send to server), so maybe not using macro could be ok-ish? Regardless, I think `SHARED_WRITE_BEGIN` is still useful though.
Right, well as things have changed a lot since then as we now have loops anyway everywhere, what about merging the seq lock within it, like this: https://gitlab.winehq.org/rbernon/wine/-/commit/6897f75798835c3a0bf2e2c7f428...