[PATCH v5 07/10] mshtml: Consolidate the functional constructors into a common struct implementation.

17 Apr 2025

From: Gabriel Ivăncescu gabrielopcode@gmail.com
Signed-off-by: Gabriel Ivăncescu gabrielopcode@gmail.com
---
Simplifies the code as well as future code, reduces boilerplate, and allows
making an extra constructor duplicate from "create" without introducing a
new object at all.
---
 dlls/mshtml/dispex.c         | 43 +++++++++++++++++--
 dlls/mshtml/htmlimg.c        | 74 ++++++--------------------------
 dlls/mshtml/htmlselect.c     | 74 ++++++--------------------------
 dlls/mshtml/mshtml_private.h | 31 +++++++-------
 dlls/mshtml/mutation.c       | 39 +++--------------
 dlls/mshtml/xmlhttprequest.c | 82 ++++++------------------------------
 6 files changed, 98 insertions(+), 245 deletions(-)

diff --git a/dlls/mshtml/dispex.c b/dlls/mshtml/dispex.c
index 1d369ce08ad..e6966a1390a 100644
--- a/dlls/mshtml/dispex.c
+++ b/dlls/mshtml/dispex.c
@@ -3053,6 +3053,31 @@ HRESULT get_prototype(HTMLInnerWindow *script_global, prototype_id_t id, Dispatc
     return S_OK;
 }
+void constructor_traverse(DispatchEx *dispex, nsCycleCollectionTraversalCallback *cb)
+{
+    struct constructor *This = constructor_from_DispatchEx(dispex);
+
+    if(This->window)
+        note_cc_edge((nsISupports*)&This->window->base.IHTMLWindow2_iface, "window", cb);
+}
+
+void constructor_unlink(DispatchEx *dispex)
+{
+    struct constructor *This = constructor_from_DispatchEx(dispex);
+
+    if(This->window) {
+        HTMLInnerWindow *window = This->window;
+        This->window = NULL;
+        IHTMLWindow2_Release(&window->base.IHTMLWindow2_iface);
+    }
+}
+
+void constructor_destructor(DispatchEx *dispex)
+{
+    struct constructor *This = constructor_from_DispatchEx(dispex);
+    free(This);
+}
+
 struct stub_constructor
 {
     DispatchEx dispex;
@@ -3123,10 +3148,20 @@ HRESULT get_constructor(HTMLInnerWindow *script_global, prototype_id_t id, Dispa
     }
info = object_descriptors[id];
-    if(info->init_constructor) {
-        HRESULT hres = info->init_constructor(script_global, &script_global->constructors[id]);
-        if(FAILED(hres))
-            return hres;
+    if(info->constructor_info) {
+        struct constructor *constr = malloc(sizeof(*constr));
+
+        if(!constr)
+            return E_OUTOFMEMORY;
+
+        constr->iface.lpVtbl = info->constructor_vtbl;
+        constr->window = script_global;
+        IHTMLWindow2_AddRef(&script_global->base.IHTMLWindow2_iface);
+
+        init_dispatch(&constr->dispex, info->constructor_info, script_global,
+                      dispex_compat_mode(&script_global->event_target.dispex));
+
+        script_global->constructors[id] = &constr->dispex;
     }else {
         struct stub_constructor *constr;
diff --git a/dlls/mshtml/htmlimg.c b/dlls/mshtml/htmlimg.c
index 518aae46213..965f6fa54a0 100644
--- a/dlls/mshtml/htmlimg.c
+++ b/dlls/mshtml/htmlimg.c
@@ -707,9 +707,9 @@ HRESULT HTMLImgElement_Create(HTMLDocumentNode *doc, nsIDOMElement *nselem, HTML
     return S_OK;
 }
-static inline HTMLImageElementFactory *impl_from_IHTMLImageElementFactory(IHTMLImageElementFactory *iface)
+static inline struct constructor *impl_from_IHTMLImageElementFactory(IHTMLImageElementFactory *iface)
 {
-    return CONTAINING_RECORD(iface, HTMLImageElementFactory, IHTMLImageElementFactory_iface);
+    return CONTAINING_RECORD(iface, struct constructor, iface);
 }
DISPEX_IDISPATCH_IMPL(HTMLImageElementFactory, IHTMLImageElementFactory,
@@ -742,7 +742,7 @@ static LONG var_to_size(const VARIANT *v)
 static HRESULT WINAPI HTMLImageElementFactory_create(IHTMLImageElementFactory *iface,
         VARIANT width, VARIANT height, IHTMLImgElement **img_elem)
 {
-    HTMLImageElementFactory *This = impl_from_IHTMLImageElementFactory(iface);
+    struct constructor *This = impl_from_IHTMLImageElementFactory(iface);
     HTMLDocumentNode *doc = This->window->doc;
     IHTMLImgElement *img;
     HTMLElement *elem;
@@ -796,51 +796,21 @@ static const IHTMLImageElementFactoryVtbl HTMLImageElementFactoryVtbl = {
     HTMLImageElementFactory_create
 };
-static inline HTMLImageElementFactory *impl_from_DispatchEx(DispatchEx *iface)
-{
-    return CONTAINING_RECORD(iface, HTMLImageElementFactory, dispex);
-}
-
 static void *HTMLImageElementFactory_query_interface(DispatchEx *dispex, REFIID riid)
 {
-    HTMLImageElementFactory *This = impl_from_DispatchEx(dispex);
+    struct constructor *This = constructor_from_DispatchEx(dispex);
if(IsEqualGUID(&IID_IHTMLImageElementFactory, riid))
-        return &This->IHTMLImageElementFactory_iface;
+        return &This->iface;
return NULL;
 }
-static void HTMLImageElementFactory_traverse(DispatchEx *dispex, nsCycleCollectionTraversalCallback *cb)
-{
-    HTMLImageElementFactory *This = impl_from_DispatchEx(dispex);
-
-    if(This->window)
-        note_cc_edge((nsISupports*)&This->window->base.IHTMLWindow2_iface, "window", cb);
-}
-
-static void HTMLImageElementFactory_unlink(DispatchEx *dispex)
-{
-    HTMLImageElementFactory *This = impl_from_DispatchEx(dispex);
-
-    if(This->window) {
-        HTMLInnerWindow *window = This->window;
-        This->window = NULL;
-        IHTMLWindow2_Release(&window->base.IHTMLWindow2_iface);
-    }
-}
-
-static void HTMLImageElementFactory_destructor(DispatchEx *dispex)
-{
-    HTMLImageElementFactory *This = impl_from_DispatchEx(dispex);
-    free(This);
-}
-
 static HRESULT HTMLImageElementFactory_value(DispatchEx *dispex, LCID lcid,
         WORD flags, DISPPARAMS *params, VARIANT *res, EXCEPINFO *ei,
         IServiceProvider *caller)
 {
-    HTMLImageElementFactory *This = impl_from_DispatchEx(dispex);
+    struct constructor *This = constructor_from_DispatchEx(dispex);
     IHTMLImgElement *img;
     VARIANT empty, *width, *height;
     HRESULT hres;
@@ -853,7 +823,7 @@ static HRESULT HTMLImageElementFactory_value(DispatchEx *dispex, LCID lcid,
     width = argc >= 1 ? params->rgvarg + (params->cArgs - 1) : &empty;
     height = argc >= 2 ? params->rgvarg + (params->cArgs - 2) : &empty;
-    hres = IHTMLImageElementFactory_create(&This->IHTMLImageElementFactory_iface, *width, *height,
+    hres = IHTMLImageElementFactory_create((IHTMLImageElementFactory*)&This->iface, *width, *height,
             &img);
     if(FAILED(hres))
         return hres;
@@ -872,38 +842,18 @@ static void HTMLImageElementFactory_init_dispex_info(dispex_data_t *info, compat
static const dispex_static_data_vtbl_t HTMLImageElementFactory_dispex_vtbl = {
     .query_interface  = HTMLImageElementFactory_query_interface,
-    .destructor       = HTMLImageElementFactory_destructor,
-    .traverse         = HTMLImageElementFactory_traverse,
-    .unlink           = HTMLImageElementFactory_unlink,
+    .destructor       = constructor_destructor,
+    .traverse         = constructor_traverse,
+    .unlink           = constructor_unlink,
     .value            = HTMLImageElementFactory_value,
 };
-static HRESULT HTMLImageElementFactory_Create(HTMLInnerWindow*,DispatchEx**);
-
 dispex_static_data_t HTMLImageElementFactory_dispex = {
     .name             = "Function",
     .constructor_id   = PROT_HTMLImageElement,
-    .init_constructor = HTMLImageElementFactory_Create,
+    .constructor_info = &HTMLImageElementFactory_dispex,
+    .constructor_vtbl = &HTMLImageElementFactoryVtbl,
     .vtbl             = &HTMLImageElementFactory_dispex_vtbl,
     .disp_tid         = IHTMLImageElementFactory_tid,
     .init_info        = HTMLImageElementFactory_init_dispex_info,
 };
-
-static HRESULT HTMLImageElementFactory_Create(HTMLInnerWindow *window, DispatchEx **ret_val)
-{
-    HTMLImageElementFactory *ret;
-
-    ret = malloc(sizeof(HTMLImageElementFactory));
-    if(!ret)
-        return E_OUTOFMEMORY;
-
-    ret->IHTMLImageElementFactory_iface.lpVtbl = &HTMLImageElementFactoryVtbl;
-    ret->window = window;
-    IHTMLWindow2_AddRef(&window->base.IHTMLWindow2_iface);
-
-    init_dispatch(&ret->dispex, &HTMLImageElementFactory_dispex, window,
-                  dispex_compat_mode(&window->event_target.dispex));
-
-    *ret_val = &ret->dispex;
-    return S_OK;
-}
diff --git a/dlls/mshtml/htmlselect.c b/dlls/mshtml/htmlselect.c
index bc45718349c..24fa61a4e9c 100644
--- a/dlls/mshtml/htmlselect.c
+++ b/dlls/mshtml/htmlselect.c
@@ -374,9 +374,9 @@ HRESULT HTMLOptionElement_Create(HTMLDocumentNode *doc, nsIDOMElement *nselem, H
     return S_OK;
 }
-static inline HTMLOptionElementFactory *impl_from_IHTMLOptionElementFactory(IHTMLOptionElementFactory *iface)
+static inline struct constructor *impl_from_IHTMLOptionElementFactory(IHTMLOptionElementFactory *iface)
 {
-    return CONTAINING_RECORD(iface, HTMLOptionElementFactory, IHTMLOptionElementFactory_iface);
+    return CONTAINING_RECORD(iface, struct constructor, iface);
 }
DISPEX_IDISPATCH_IMPL(HTMLOptionElementFactory, IHTMLOptionElementFactory,
@@ -386,7 +386,7 @@ static HRESULT WINAPI HTMLOptionElementFactory_create(IHTMLOptionElementFactory
         VARIANT text, VARIANT value, VARIANT defaultselected, VARIANT selected,
         IHTMLOptionElement **optelem)
 {
-    HTMLOptionElementFactory *This = impl_from_IHTMLOptionElementFactory(iface);
+    struct constructor *This = impl_from_IHTMLOptionElementFactory(iface);
     nsIDOMElement *nselem;
     HTMLDOMNode *node;
     HRESULT hres;
@@ -438,51 +438,21 @@ static const IHTMLOptionElementFactoryVtbl HTMLOptionElementFactoryVtbl = {
     HTMLOptionElementFactory_create
 };
-static inline HTMLOptionElementFactory *HTMLOptionElementFactory_from_DispatchEx(DispatchEx *iface)
-{
-    return CONTAINING_RECORD(iface, HTMLOptionElementFactory, dispex);
-}
-
 static void *HTMLOptionElementFactory_query_interface(DispatchEx *dispex, REFIID riid)
 {
-    HTMLOptionElementFactory *This = HTMLOptionElementFactory_from_DispatchEx(dispex);
+    struct constructor *This = constructor_from_DispatchEx(dispex);
if(IsEqualGUID(&IID_IHTMLOptionElementFactory, riid))
-        return &This->IHTMLOptionElementFactory_iface;
+        return &This->iface;
return NULL;
 }
-static void HTMLOptionElementFactory_traverse(DispatchEx *dispex, nsCycleCollectionTraversalCallback *cb)
-{
-    HTMLOptionElementFactory *This = HTMLOptionElementFactory_from_DispatchEx(dispex);
-
-    if(This->window)
-        note_cc_edge((nsISupports*)&This->window->base.IHTMLWindow2_iface, "window", cb);
-}
-
-static void HTMLOptionElementFactory_unlink(DispatchEx *dispex)
-{
-    HTMLOptionElementFactory *This = HTMLOptionElementFactory_from_DispatchEx(dispex);
-
-    if(This->window) {
-        HTMLInnerWindow *window = This->window;
-        This->window = NULL;
-        IHTMLWindow2_Release(&window->base.IHTMLWindow2_iface);
-    }
-}
-
-static void HTMLOptionElementFactory_destructor(DispatchEx *dispex)
-{
-    HTMLOptionElementFactory *This = HTMLOptionElementFactory_from_DispatchEx(dispex);
-    free(This);
-}
-
 static HRESULT HTMLOptionElementFactory_value(DispatchEx *dispex, LCID lcid,
         WORD flags, DISPPARAMS *params, VARIANT *res, EXCEPINFO *ei,
         IServiceProvider *caller)
 {
-    HTMLOptionElementFactory *This = HTMLOptionElementFactory_from_DispatchEx(dispex);
+    struct constructor *This = constructor_from_DispatchEx(dispex);
     unsigned int i, argc = params->cArgs - params->cNamedArgs;
     IHTMLOptionElement *opt;
     VARIANT empty, *arg[4];
@@ -499,7 +469,7 @@ static HRESULT HTMLOptionElementFactory_value(DispatchEx *dispex, LCID lcid,
     for(i = 0; i < ARRAY_SIZE(arg); i++)
         arg[i] = argc > i ? &params->rgvarg[params->cArgs - 1 - i] : &empty;
-    hres = IHTMLOptionElementFactory_create(&This->IHTMLOptionElementFactory_iface,
+    hres = IHTMLOptionElementFactory_create((IHTMLOptionElementFactory*)&This->iface,
                                             *arg[0], *arg[1], *arg[2], *arg[3], &opt);
     if(FAILED(hres))
         return hres;
@@ -518,42 +488,22 @@ static void HTMLImageElementFactory_init_dispex_info(dispex_data_t *info, compat
static const dispex_static_data_vtbl_t HTMLOptionElementFactory_dispex_vtbl = {
     .query_interface  = HTMLOptionElementFactory_query_interface,
-    .destructor       = HTMLOptionElementFactory_destructor,
-    .traverse         = HTMLOptionElementFactory_traverse,
-    .unlink           = HTMLOptionElementFactory_unlink,
+    .destructor       = constructor_destructor,
+    .traverse         = constructor_traverse,
+    .unlink           = constructor_unlink,
     .value            = HTMLOptionElementFactory_value,
 };
-static HRESULT HTMLOptionElementFactory_Create(HTMLInnerWindow*,DispatchEx**);
-
 dispex_static_data_t HTMLOptionElementFactory_dispex = {
     .name             = "Function",
     .constructor_id   = PROT_HTMLOptionElement,
-    .init_constructor = HTMLOptionElementFactory_Create,
+    .constructor_info = &HTMLOptionElementFactory_dispex,
+    .constructor_vtbl = &HTMLOptionElementFactoryVtbl,
     .vtbl             = &HTMLOptionElementFactory_dispex_vtbl,
     .disp_tid         = IHTMLOptionElementFactory_tid,
     .init_info        = HTMLImageElementFactory_init_dispex_info,
 };
-static HRESULT HTMLOptionElementFactory_Create(HTMLInnerWindow *window, DispatchEx **ret_ptr)
-{
-    HTMLOptionElementFactory *ret;
-
-    ret = malloc(sizeof(*ret));
-    if(!ret)
-        return E_OUTOFMEMORY;
-
-    ret->IHTMLOptionElementFactory_iface.lpVtbl = &HTMLOptionElementFactoryVtbl;
-    ret->window = window;
-    IHTMLWindow2_AddRef(&window->base.IHTMLWindow2_iface);
-
-    init_dispatch(&ret->dispex, &HTMLOptionElementFactory_dispex, window,
-                  dispex_compat_mode(&window->event_target.dispex));
-
-    *ret_ptr = &ret->dispex;
-    return S_OK;
-}
-
 struct HTMLSelectElement {
     HTMLElement element;
diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h
index d5e93d2ef56..0e13aa26f7e 100644
--- a/dlls/mshtml/mshtml_private.h
+++ b/dlls/mshtml/mshtml_private.h
@@ -529,7 +529,8 @@ struct dispex_static_data_t {
     const tid_t disp_tid;
     const tid_t* const iface_tids;
     void (*init_info)(dispex_data_t*,compat_mode_t);
-    HRESULT (*init_constructor)(HTMLInnerWindow*,DispatchEx**);
+    dispex_static_data_t *constructor_info;
+    const void *constructor_vtbl;
     dispex_data_t *info_cache[COMPAT_MODE_CNT];
     dispex_data_t *prototype_info[COMPAT_MODE_CNT - COMPAT_MODE_IE9];
     dispex_data_t *delayed_init_info;
@@ -667,6 +668,20 @@ typedef enum {
dispex_prop_type_t get_dispid_type(DISPID);
+struct constructor {
+    DispatchEx dispex;
+    IUnknown iface;
+    HTMLInnerWindow *window;
+};
+
+static inline struct constructor *constructor_from_DispatchEx(DispatchEx *iface)
+{
+    return CONTAINING_RECORD(iface, struct constructor, dispex);
+}
+void constructor_traverse(DispatchEx*,nsCycleCollectionTraversalCallback*);
+void constructor_unlink(DispatchEx*);
+void constructor_destructor(DispatchEx*);
+
 typedef enum {
     GLOBAL_SCRIPTVAR,
     GLOBAL_ELEMENTVAR,
@@ -687,20 +702,6 @@ struct EventTarget {
     struct wine_rb_tree handler_map;
 };
-typedef struct {
-    DispatchEx dispex;
-    IHTMLOptionElementFactory IHTMLOptionElementFactory_iface;
-
-    HTMLInnerWindow *window;
-} HTMLOptionElementFactory;
-
-typedef struct {
-    DispatchEx dispex;
-    IHTMLImageElementFactory IHTMLImageElementFactory_iface;
-
-    HTMLInnerWindow *window;
-} HTMLImageElementFactory;
-
 struct HTMLLocation {
     DispatchEx dispex;
     IHTMLLocation IHTMLLocation_iface;
diff --git a/dlls/mshtml/mutation.c b/dlls/mshtml/mutation.c
index a203c03e2dc..1642bb4a065 100644
--- a/dlls/mshtml/mutation.c
+++ b/dlls/mshtml/mutation.c
@@ -1198,8 +1198,6 @@ static void mutation_observer_destructor(DispatchEx *dispex)
     free(This);
 }
-static HRESULT create_mutation_observer_ctor(HTMLInnerWindow *script_global, DispatchEx **ret);
-
 static const dispex_static_data_vtbl_t mutation_observer_dispex_vtbl = {
     .query_interface  = mutation_observer_query_interface,
     .destructor       = mutation_observer_destructor,
@@ -1207,13 +1205,15 @@ static const dispex_static_data_vtbl_t mutation_observer_dispex_vtbl = {
     .unlink           = mutation_observer_unlink
 };
+static dispex_static_data_t mutation_observer_ctor_dispex;
+
 static const tid_t mutation_observer_iface_tids[] = {
     IWineMSHTMLMutationObserver_tid,
     0
 };
 dispex_static_data_t MutationObserver_dispex = {
     .id               = PROT_MutationObserver,
-    .init_constructor = create_mutation_observer_ctor,
+    .constructor_info = &mutation_observer_ctor_dispex,
     .vtbl             = &mutation_observer_dispex_vtbl,
     .disp_tid         = IWineMSHTMLMutationObserver_tid,
     .iface_tids       = mutation_observer_iface_tids,
@@ -1247,22 +1247,11 @@ struct mutation_observer_ctor {
     DispatchEx dispex;
 };
-static inline struct mutation_observer_ctor *mutation_observer_ctor_from_DispatchEx(DispatchEx *iface)
-{
-    return CONTAINING_RECORD(iface, struct mutation_observer_ctor, dispex);
-}
-
-static void mutation_observer_ctor_destructor(DispatchEx *dispex)
-{
-    struct mutation_observer_ctor *This = mutation_observer_ctor_from_DispatchEx(dispex);
-    free(This);
-}
-
 static HRESULT mutation_observer_ctor_value(DispatchEx *dispex, LCID lcid,
         WORD flags, DISPPARAMS *params, VARIANT *res, EXCEPINFO *ei,
         IServiceProvider *caller)
 {
-    struct mutation_observer_ctor *This = mutation_observer_ctor_from_DispatchEx(dispex);
+    struct constructor *This = constructor_from_DispatchEx(dispex);
     VARIANT *callback;
     IWineMSHTMLMutationObserver *mutation_observer;
     HRESULT hres;
@@ -1305,7 +1294,7 @@ static HRESULT mutation_observer_ctor_value(DispatchEx *dispex, LCID lcid,
 }
static const dispex_static_data_vtbl_t mutation_observer_ctor_dispex_vtbl = {
-    .destructor       = mutation_observer_ctor_destructor,
+    .destructor       = constructor_destructor,
     .value            = mutation_observer_ctor_value
 };
@@ -1314,21 +1303,3 @@ static dispex_static_data_t mutation_observer_ctor_dispex = {
     .constructor_id = PROT_MutationObserver,
     .vtbl           = &mutation_observer_ctor_dispex_vtbl,
 };
-
-static HRESULT create_mutation_observer_ctor(HTMLInnerWindow *script_global, DispatchEx **ret)
-{
-    struct mutation_observer_ctor *obj;
-
-    obj = calloc(1, sizeof(*obj));
-    if(!obj)
-    {
-        ERR("No memory.\n");
-        return E_OUTOFMEMORY;
-    }
-
-    init_dispatch(&obj->dispex, &mutation_observer_ctor_dispex, script_global,
-                  dispex_compat_mode(&script_global->event_target.dispex));
-
-    *ret = &obj->dispex;
-    return S_OK;
-}
diff --git a/dlls/mshtml/xmlhttprequest.c b/dlls/mshtml/xmlhttprequest.c
index cadf2909a07..e6324a9288a 100644
--- a/dlls/mshtml/xmlhttprequest.c
+++ b/dlls/mshtml/xmlhttprequest.c
@@ -36,13 +36,6 @@
WINE_DEFAULT_DEBUG_CHANNEL(mshtml);
-typedef struct {
-    DispatchEx dispex;
-    IHTMLXMLHttpRequestFactory IHTMLXMLHttpRequestFactory_iface;
-
-    HTMLInnerWindow *window;
-} HTMLXMLHttpRequestFactory;
-
 static HRESULT bstr_to_nsacstr(BSTR bstr, nsACString *str)
 {
     char *cstr = strdupWtoU(bstr);
@@ -1489,7 +1482,8 @@ static const event_target_vtbl_t HTMLXMLHttpRequest_event_target_vtbl = {
     .bind_event              = HTMLXMLHttpRequest_bind_event
 };
-static HRESULT HTMLXMLHttpRequestFactory_Create(HTMLInnerWindow*,DispatchEx**);
+static const IHTMLXMLHttpRequestFactoryVtbl HTMLXMLHttpRequestFactoryVtbl;
+static dispex_static_data_t HTMLXMLHttpRequestFactory_dispex;
static const tid_t HTMLXMLHttpRequest_iface_tids[] = {
     IHTMLXMLHttpRequest2_tid,
@@ -1497,7 +1491,8 @@ static const tid_t HTMLXMLHttpRequest_iface_tids[] = {
 };
 dispex_static_data_t XMLHttpRequest_dispex = {
     .id               = PROT_XMLHttpRequest,
-    .init_constructor = HTMLXMLHttpRequestFactory_Create,
+    .constructor_info = &HTMLXMLHttpRequestFactory_dispex,
+    .constructor_vtbl = &HTMLXMLHttpRequestFactoryVtbl,
     .vtbl             = &HTMLXMLHttpRequest_event_target_vtbl.dispex_vtbl,
     .disp_tid         = DispHTMLXMLHttpRequest_tid,
     .iface_tids       = HTMLXMLHttpRequest_iface_tids,
@@ -1506,9 +1501,9 @@ dispex_static_data_t XMLHttpRequest_dispex = {
/* IHTMLXMLHttpRequestFactory */
-static inline HTMLXMLHttpRequestFactory *impl_from_IHTMLXMLHttpRequestFactory(IHTMLXMLHttpRequestFactory *iface)
+static inline struct constructor *impl_from_IHTMLXMLHttpRequestFactory(IHTMLXMLHttpRequestFactory *iface)
 {
-    return CONTAINING_RECORD(iface, HTMLXMLHttpRequestFactory, IHTMLXMLHttpRequestFactory_iface);
+    return CONTAINING_RECORD(iface, struct constructor, iface);
 }
DISPEX_IDISPATCH_IMPL(HTMLXMLHttpRequestFactory, IHTMLXMLHttpRequestFactory,
@@ -1516,7 +1511,7 @@ DISPEX_IDISPATCH_IMPL(HTMLXMLHttpRequestFactory, IHTMLXMLHttpRequestFactory,
static HRESULT WINAPI HTMLXMLHttpRequestFactory_create(IHTMLXMLHttpRequestFactory *iface, IHTMLXMLHttpRequest **p)
 {
-    HTMLXMLHttpRequestFactory *This = impl_from_IHTMLXMLHttpRequestFactory(iface);
+    struct constructor        *This = impl_from_IHTMLXMLHttpRequestFactory(iface);
     HTMLXMLHttpRequest        *ret;
     nsIXMLHttpRequest         *nsxhr;
     nsIDOMEventTarget         *nstarget;
@@ -1593,50 +1588,20 @@ static const IHTMLXMLHttpRequestFactoryVtbl HTMLXMLHttpRequestFactoryVtbl = {
     HTMLXMLHttpRequestFactory_create
 };
-static inline HTMLXMLHttpRequestFactory *factory_from_DispatchEx(DispatchEx *iface)
-{
-    return CONTAINING_RECORD(iface, HTMLXMLHttpRequestFactory, dispex);
-}
-
 static void *HTMLXMLHttpRequestFactory_query_interface(DispatchEx *dispex, REFIID riid)
 {
-    HTMLXMLHttpRequestFactory *This = factory_from_DispatchEx(dispex);
+    struct constructor *This = constructor_from_DispatchEx(dispex);
if(IsEqualGUID(&IID_IHTMLXMLHttpRequestFactory, riid))
-        return &This->IHTMLXMLHttpRequestFactory_iface;
+        return &This->iface;
return NULL;
 }
-static void HTMLXMLHttpRequestFactory_traverse(DispatchEx *dispex, nsCycleCollectionTraversalCallback *cb)
-{
-    HTMLXMLHttpRequestFactory *This = factory_from_DispatchEx(dispex);
-
-    if(This->window)
-        note_cc_edge((nsISupports*)&This->window->base.IHTMLWindow2_iface, "window", cb);
-}
-
-static void HTMLXMLHttpRequestFactory_unlink(DispatchEx *dispex)
-{
-    HTMLXMLHttpRequestFactory *This = factory_from_DispatchEx(dispex);
-
-    if(This->window) {
-        HTMLInnerWindow *window = This->window;
-        This->window = NULL;
-        IHTMLWindow2_Release(&window->base.IHTMLWindow2_iface);
-    }
-}
-
-static void HTMLXMLHttpRequestFactory_destructor(DispatchEx *dispex)
-{
-    HTMLXMLHttpRequestFactory *This = factory_from_DispatchEx(dispex);
-    free(This);
-}
-
 static HRESULT HTMLXMLHttpRequestFactory_value(DispatchEx *iface, LCID lcid, WORD flags, DISPPARAMS *params,
         VARIANT *res, EXCEPINFO *ei, IServiceProvider *caller)
 {
-    HTMLXMLHttpRequestFactory *This = factory_from_DispatchEx(iface);
+    struct constructor *This = constructor_from_DispatchEx(iface);
     IHTMLXMLHttpRequest *xhr;
     HRESULT hres;
@@ -1647,7 +1612,7 @@ static HRESULT HTMLXMLHttpRequestFactory_value(DispatchEx *iface, LCID lcid, WOR
         return E_NOTIMPL;
     }
-    hres = IHTMLXMLHttpRequestFactory_create(&This->IHTMLXMLHttpRequestFactory_iface, &xhr);
+    hres = IHTMLXMLHttpRequestFactory_create((IHTMLXMLHttpRequestFactory*)&This->iface, &xhr);
     if(FAILED(hres))
         return hres;
@@ -1658,9 +1623,9 @@ static HRESULT HTMLXMLHttpRequestFactory_value(DispatchEx *iface, LCID lcid, WOR
static const dispex_static_data_vtbl_t HTMLXMLHttpRequestFactory_dispex_vtbl = {
     .query_interface  = HTMLXMLHttpRequestFactory_query_interface,
-    .destructor       = HTMLXMLHttpRequestFactory_destructor,
-    .traverse         = HTMLXMLHttpRequestFactory_traverse,
-    .unlink           = HTMLXMLHttpRequestFactory_unlink,
+    .destructor       = constructor_destructor,
+    .traverse         = constructor_traverse,
+    .unlink           = constructor_unlink,
     .value            = HTMLXMLHttpRequestFactory_value
 };
@@ -1675,22 +1640,3 @@ static dispex_static_data_t HTMLXMLHttpRequestFactory_dispex = {
     .disp_tid       = IHTMLXMLHttpRequestFactory_tid,
     .iface_tids     = HTMLXMLHttpRequestFactory_iface_tids,
 };
-
-static HRESULT HTMLXMLHttpRequestFactory_Create(HTMLInnerWindow *window, DispatchEx **ret_ptr)
-{
-    HTMLXMLHttpRequestFactory *ret;
-
-    ret = malloc(sizeof(*ret));
-    if(!ret)
-        return E_OUTOFMEMORY;
-
-    ret->IHTMLXMLHttpRequestFactory_iface.lpVtbl = &HTMLXMLHttpRequestFactoryVtbl;
-    ret->window = window;
-    IHTMLWindow2_AddRef(&window->base.IHTMLWindow2_iface);
-
-    init_dispatch(&ret->dispex, &HTMLXMLHttpRequestFactory_dispex, window,
-                  dispex_compat_mode(&window->event_target.dispex));
-
-    *ret_ptr = &ret->dispex;
-    return S_OK;
-}
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/7779

    

2025

2024

2023

2022

[PATCH v5 07/10] mshtml: Consolidate the functional constructors into a common struct implementation.