Re: [PATCH 0/6] MR536: xactengine3_7: Add helper function to add entries

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about dlls/xactengine3_7/xact_dll.c:
> -
>    xnotification.wave.cueIndex = notification->wave.cueIndex;
> -
>    xnotification.wave.pCue = wrapper_find_entry(engine, notification->wave.pCue);
> -
>    xnotification.wave.pSoundBank = wrapper_find_entry(engine, notification->wave.pSoundBank);
>
> +#if XACT3_VER >= 0x0205
> -
>    xnotification.wave.pWave = wrapper_find_entry(engine, notification->wave.pWave);
>
> +#endif
> -
>    xnotification.wave.pWaveBank = wrapper_find_entry(engine, notification->wave.pWaveBank);
> - }
> - else if (notification->type == XACTNOTIFICATIONTYPE_CUEPLAY ||
> -
>         notification->type == XACTNOTIFICATIONTYPE_CUEPREPARED ||
> -
>         notification->type == XACTNOTIFICATIONTYPE_CUESTOP ||
> -
>         notification->type == XACTNOTIFICATIONTYPE_CUEDESTROYED)
> - {
> -
>    xnotification.cue.pCue = wrapper_find_entry(engine, notification->cue.pCue);
> -
>    xnotification.cue.cueIndex = notification->cue.cueIndex;
> -
>    xnotification.cue.pSoundBank = wrapper_find_entry(engine, notification->cue.pSoundBank);

It doesn't look like all these notifications are implemented in FAudio, though. For example, I cannot find in the code where `CUEPREPARED` would be notified. Here too it wouldn't be bad to have some tests.