Re: [PATCH v15 0/4] MR4661: gdiplus: Implement Gdiplus effects

[Esme Povirk (＠madewokherd)]

Esme Povirk (@madewokherd) commented about dlls/gdiplus/image.c:
>  {
>      ef = malloc(sizeof(CGpEffect));
>      ef->type = ColorBalanceEffect;
> -
>    ef->p.clrbalanceparams = NULL;
> }
>    else if (IsEqualGUID(&guid, &LevelsEffectGuid))
>    {
>        ef = malloc(sizeof(CGpEffect));
>        ef->type = LevelsEffect;
> -
>    ef->p.levelsparams = NULL;
> }
>    else if (IsEqualGUID(&guid, &ColorCurveEffectGuid))
>    {
>        ef = malloc(sizeof(CGpEffect));
>        ef->type = ColorCurveEffect;
> -
>    ef->p.clrcurveparams = NULL;

I don't think it makes sense to duplicate this assignment to NULL. I would just have a member of the union that is a BYTE* and use that when the type doesn't matter.