26 Nov
2023
26 Nov
'23
7:02 p.m.
On Sun Nov 26 19:02:09 2023 +0000, Nikolay Sivov wrote:
I would also include configure.ac changes when adding a stub, otherwise this only builds after running make_makefiles, which CI does. I don't know if this is required. Regarding more formatting changes, I would do more for those simple functions, including trace messages and some naming, but others might disagree.
My last knowledge was that I should never check in configure changes that are automatically regenerated. Just tell me if that changed, and I can check in those parts as well.
I don't know how much cleanup exactly should be done, if I get a clear requirement I will do it.