Re: [PATCH 3/3] wine/test.h: WINETEST_COLOR=auto only outputs colors to a TTY.

[Zebediah Figura (she/her)]

On 8/3/22 02:54, Eric Pouech wrote:
> @@ -676,7 +677,8 @@ int main( int argc, char **argv )
>       else if (running_under_wine())
>           winetest_platform = "wine";
> - if (GetEnvironmentVariableA( "WINETEST_COLOR", p, sizeof(p) )) winetest_color = atoi(p);
> - if (GetEnvironmentVariableA( "WINETEST_COLOR", p, sizeof(p) ))
> -
>    winetest_color = !strcasecmp(p, "auto") ? isatty(fileno(stdout)) : atoi(p);
> if (GetEnvironmentVariableA( "WINETEST_DEBUG", p, sizeof(p) )) winetest_debug = atoi(p);
> if (GetEnvironmentVariableA( "WINETEST_INTERACTIVE", p, sizeof(p) )) winetest_interactive = atoi(p);
> if (GetEnvironmentVariableA( "WINETEST_REPORT_SUCCESS", p, sizeof(p) )) winetest_report_success = atoi(p);

I didn't do this in the first place because by my understanding, 
isatty() alone isn't enough to ensure the terminal supports ANSI escape 
sequences, neither for Windows nor (host) Unix terminals.

We probably need to use SetConsoleMode(ENABLE_VIRTUAL_TERMINAL_INPUT), 
but that doesn't currently work correctly under Wine.