Re: [PATCH v21 0/5] MR564: vkd3d-shader/ir: Transform clip/cull signature elements into an array.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/ir.c:
> - {
> -
>    vkd3d_free(program->instructions.elements);
> -
>    program->instructions.elements = normaliser.instructions;
> -
>    program->instructions.capacity = normaliser.instruction_capacity;
> -
>    program->instructions.count = normaliser.instruction_count;
> -
> -
>    program->temp_count += normaliser.temp_count;
> -
> -
>    return VKD3D_OK;
> - }
> - else
> - {
> -
>    if (normaliser.result == VKD3D_ERROR_OUT_OF_MEMORY)
> -
>    {
> -
>        clip_cull_normaliser_error(&normaliser, VKD3D_SHADER_ERROR_VSIR_OUT_OF_MEMORY,
> -
>                "Out of memory allocating clip/cull normalization instructions.\n");

Not a problem, but in general I don't think we care too much about emitting explicit errors for memory allocation failures.