Re: [PATCH v16 0/4] MR6423: Implement NtQuerySystemEnvironmentValueEx, NtQuerySystemInformation SystemBootEnvironmentInformation, GetFirmwareType, GetFirmwareEnvironmentVariable*

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/ntdll/unix/system.c:
> - fd = open(filename, O_RDONLY | O_NONBLOCK);
> - if (fd < 0)
> -
>    goto done;
> -
> - rc = fstat(fd, &stat_info);
> - if (rc < 0 || stat_info.st_size == 0)
> -
>    goto done;
> -
>
> +try_read_attributes:
> - ssz = read(fd, attrib, 4);
> - if (ssz < 0)
> - {
> -
>    if (errno == EAGAIN || errno == EINTR)
> -
>        goto try_read_attributes;
> -
>    goto done;
> - }

I'd rather returned error instead of retrying.