Re: [PATCH v5 0/4] MR4852: Add support from AudioPathConfig

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/dmime/performance.c:
> - }
> - else
> -
>    FIXME("Multiple buffers not supported\n");
> -
> - port_params = port_config->params;
> - if (!(port_params.dwValidParams & DMUS_PORTPARAMS_CHANNELGROUPS))
> - {
> -
>    port_params.dwValidParams |= DMUS_PORTPARAMS_CHANNELGROUPS;
> -
>    port_params.dwChannelGroups = (port_config->header.dwPChannelCount + 15) / 16;
> - }
> - if (!(port_params.dwValidParams & DMUS_PORTPARAMS_AUDIOCHANNELS))
> - {
> -
>    port_params.dwValidParams |= DMUS_PORTPARAMS_AUDIOCHANNELS;
> -
>    port_params.dwAudioChannels = format.nChannels;
> - }
> - hr = perf_dmport_create(This, &port_config->params);

Shouldn't this be using `&port_params`?